Have you ever considered using patches from UXP?

Aura Maxima's Avatar

Aura Maxima

18 May, 2018 04:17 PM

I think the title doesn't need to be further explained. The upcoming UXP platform delivers some valuable improvements in various areas; is there any specific reason why we are not making use of that?

-> https://github.com/MoonchildProductions/UXP

The platform doesn't build on WebExtensions, e10s, or Rust. Should be an ideal source of patches for us. Why aren't many fixes and improvements ported over to TFF? This feels like a missed opportunity.

  1. Support Staff 1 Posted by Cameron Kaiser on 18 May, 2018 10:45 PM

    Cameron Kaiser's Avatar

    TenFourFox is a superset of Firefox 45ESR. Near as I can determine, UXP is actually based on overlays to 52ESR (rather than backpatching ESR52 improvements to the existing browser base, which on my best guess is approximately 38ESR). There are several significant platform changes with ESR52 that are unsuitable for 10.4, including endian issues with the internationalization library and the requirement for Skia as the video base (and the loss of our customized CoreGraphics library, which would be a big performance hit). Taking the whole of the web changes between Fx45 and Fx52 but getting around the compatibility platform changes would require substantial work, so we stay on Fx45 as the base and add to that. UXP takes 52ESR as a whole, so using it as a source wouldn't help much because of trying to atomically separate the feature changes we want from the platform changes we don't.

    Also note that because of the work done so far, TenFourFox FPR7 already supports a substantial number of features from Fx52, so much so that many sites work fine if the user agent is changed.

  2. 2 Posted by Aura Maxima on 19 May, 2018 07:56 AM

    Aura Maxima's Avatar

    @Cameron Kaiser

    I know that the FF52 ESR base is not suitable, as I have followed your rather informative and entertaining blog posts. :-)
    I didn't mean to base TFF off UXP, I was just leaning towards fetching selected patches from there. They could be more easily ported than those from newer Firefox releases, I assume. The code is not as heavily rewritten.

    I want the TFF project to still go strong in the future, and I thought this could be a viable way to keep it up to date. I'd consider following the UXP repository and sometimes picking viable patches from there as well. The Pale Moon team has fixed notable bugs, e.g. Bug 1241717:

    https://bugzilla.mozilla.org/show_bug.cgi?id=1241717

    with these commits:

    https://github.com/MoonchildProductions/Pale-Moon/commit/665ce3a5f1814c98bcd05f5611d1079ab99fd5d1
    https://github.com/MoonchildProductions/Pale-Moon/commit/dab2fee747d1853d5e081f69750869d45b7cf6b0

    I would like to see such fixes appear in TFF as well, that's all. ;-)

Reply to this discussion

Internal reply

Formatting help / Preview (switch to plain text) No formatting (switch to Markdown)

Attaching KB article:

»

Attached Files

You can attach files up to 10MB

If you don't have an account yet, we need to confirm you're human and not a machine trying to post spam.

Keyboard shortcuts

Generic

? Show this help
ESC Blurs the current field

Comment Form

r Focus the comment reply box
^ + ↩ Submit the comment

You can use Command ⌘ instead of Control ^ on Mac

Recent Discussions

20 Jul, 2018 09:42 AM
20 Jul, 2018 04:42 AM
18 Jul, 2018 05:24 AM
16 Jul, 2018 12:04 AM
14 Jul, 2018 05:46 PM